Update instrument sample names #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you considered including some kind of text document, including the details for the original samples, that have been discovered by the community? Here is a link to the spreadsheets maintained by that group |
|
maybe following a format similar to what Nintendo internally used as it contains not only the sample's name and tuning, but also its sample rate in kHz and the initial of its author's surname (although that'd be less applicable, but regarding music samples it seems to always be the composer's initial, with Kondo being SM64's only composer, making them all k) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-All instruments with tuning have respective base key in the sample name
-A couple sample names were added since their origins have been found (i.e. tabla riffs)